[Shotwell] Getting 0.3.0 to build

[Jim Nelson]

Hi Matthias,

Thanks for these patches.  No, we do not want to be Ubuntu-specific
here, it's just the distro we're the most familiar with.  So anything
you can suggest that helps Shotwell build everywhere (or at least with
all major distros) is welcome.

Your patches mostly make sense to me.  I do have a few questions:

* I'm not thrilled about running the cache updaters from make install,
but we do want people to be able to install Shotwell without using a
package manager.  (We have nothing against package managers, of
course.)  Are you suggesting we merely copy the schema/desktop files
and omit the update step, and assume that the caches will update at
some point in the future?  My concern here is that without the cache
updates the install doesn't "feel" complete (i.e., the icon doesn't
display in the Applications menu).  Or, are you saying Makefile should
respect GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL to decide if it should
run the cache updater?

* I'm also not thrilled about sending a HUP signal in a Makefile.
We'd found docs online suggesting this was necessary.  We'll probably
just forgo the step ... it smells of patchwork and hackery.

* In your Makefile patch the gcc options use -O2 for a debug build.
Is this the norm?  I find -O0 useful when, well, debugging, especially
under gdb.

* -m64 makes Shotwell impossible to build on 32-bit based installs
(i.e. my own machine).  Shouldn't this just be omitted?

* I'm having trouble finding good docs on -fexceptions.  This seems to
be more appropriate for C++.  You do know that Vala generates its own
exception handling and stack unwinding in straight C?

* Also, your gcc options remove some of the floating-point
optimizations we included for the color transformation code.  Is there
a problem with leaving these in?

Thanks for this help.  We are planning a 0.3.1 release which will
incorporate these changes.  Stay tuned!

-- Jim



On Tue, Nov 3, 2009 at 3:28 PM, Matthias Clasen
<matthias.clasen at gmail.com> wrote:
> Hey,
>
> congratulations on 0.3.0, it is looking pretty sweet indeed.
>
> I had to hack around a bit in the Makefile to make it build on Fedora.
> You seem to have accumulated some Ubuntuisms there :-)
> I'll attach my patches. The short summary is:
>
> - Running cache-updaters like update-desktop-database, gconftool-2,
> etc from 'make install' is not really best for packaging. It would be
> nice if there was a way to omit that and have make install just put
> the files down. For gconf schemas, the de-facto standard for this is
> export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1
>
> - GConf schemas should be installed (usually in
> $sysconfdir/gconf/schemas, but it varies a bit between distros)
>
> - update-icon-caches is not available here - GTK+ ships gtk-update-icon-cache
>
> - SYSTEM_LANG_DIR should be $(DESTDIR)$(PREFIX)/share/locale unless
> you want to be really Ubuntu-centric. And even if you want to,
> $(DESTDIR)$(PREFIX) is missing
>
> - killall -HUP gconfd-2 will return nonzero and interrupt the install
> if there is no gconfd running
>
>
> Matthias
>
> _______________________________________________
> Shotwell mailing list
> Shotwell at lists.yorba.org
> http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
>
>